Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CircleCI config to run GCP Acceptance tests #937

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Prepare CircleCI config to run GCP Acceptance tests #937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e21409
Update CircleCI config to use GCP Acceptance tests
usmansaleem Nov 3, 2023
22652cb
Merge remote-tracking branch 'upstream/master' into circleci_gcp_at
usmansaleem Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@ jobs:
name: Acceptance Tests
no_output_timeout: 20m
command: |
if [ -n "$GCP_SERVICE_KEY" ]; then
echo "$GCP_SERVICE_KEY" | base64 --decode > $HOME/gcp_service_key.json
export GOOGLE_APPLICATION_CREDENTIALS=$HOME/gcp_service_key.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for our ATs with how they work or will users also have to set the GOOGLE_APPLICATION_CREDENTIALS environment variable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just have the AT use the GCP_SERVICE_KEY env variable instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users, as well as web3signer developers, have to use "Application Default Credentials ADC) to setup authentication. We are using service user approach which uses service user key and GOOGLE_APPLICATION_CREDENTIALS environment variable. https://cloud.google.com/docs/authentication/provide-credentials-adc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not nice. It means we can't use our typical config and env variable approach. And google becomes a special case that is more difficult to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our ATs it's fine though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: think it would be clearer if GCP_SERVICE_KEY was called GCP_SERVICE_KEY_BASE64

fi
./gradlew --no-daemon clean installDist
./gradlew --no-daemon --parallel acceptanceTest
- notify
Expand Down