Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KZG as it is not needed by web3signer #935

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Remove KZG as it is not needed by web3signer #935

merged 3 commits into from
Nov 1, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Oct 31, 2023 •
edited
Loading

PR Description

Remove KZG as it is not needed by web3signer. This also removes the need to specify the trusted setup when using a custom network.

  • Removed the js dependency vulnerability scanning as we don't use js and it's broken the build
  • Removed the .net assembly scanner as it logs warning messages and we don't use it
  • Upgraded Teku to latest version 23.10.0
  • Changed spec to be initialised with the kzgNoop enabled
  • Removed -Xtrusted-setup command line option since we no longer need it

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@jframe jframe merged commit 6d3fa09 into Consensys:master Nov 1, 2023
2 checks passed
@jframe jframe deleted the remove_kzg_trusted_setup branch November 1, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @siladu