feat: Remove stale validator keys during reload #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmansaleem
added
the
doc-change-required
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Outdated
Show resolved
Hide resolved
jframe
requested changes
Jan 16, 2025
| final Map<String, ArtifactSigner> oldSigners = new HashMap<>(signers); | ||
| // step 2: Clear current signers and then load them via ArtifactSignerCollectionSupplier | ||
| if (!reloadKeepStaleKeys) { | ||
| signers.clear(); |
There was a problem hiding this comment.
Doing this clear means there will be no signers loaded and will possibly fail some signing requests for keys aren't going to be unloaded. Can this be done without clearing the existing signers and just applying the delta to add and remove entries from the existing signer's map?
| jdbi.useTransaction( | ||
| handle -> { | ||
| // disable the validators in the database | ||
| staleValidators.forEach( |
There was a problem hiding this comment.
Why are the stale validators disabled after removing from the signers map? This will affect all web3signer instances using the same database. The validator is already removed from the signers map so don't see why disabling them is necessary.
…ng logic to avoid clearing the map. Also made sure maps are thread-safe by using concurrent maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Remove stale validator keys during reload API call. The stale keys will not be listed in public keys API call after reload. They are also disabled in slashing database in eth2 mode.
Due to this PR, the behavior of reload API endpoint has been modified. It will remove all in-memory keys before loading them again using configuration files and bulk loading. This unfortunately results in behaviour change of local configuration files pointing to encrypted keystores. Previously cached local configuration files were avoided being reloaded during reload API call, now they will be reloaded and reparsed. To keep the old behavior
--reload-keep-stale-keys=trueoption can be used which will not remove stale keys during reload API call.Fixed Issue(s)
Fixes #1018
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing