Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log4j: replace status (deprecated) with level #1050

Merged
merged 1 commit into from
Jan 13, 2025
Merged

log4j: replace status (deprecated) with level #1050

merged 1 commit into from
Jan 13, 2025

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jan 8, 2025 •
edited
Loading

The attribute status has been deprecated in log4j since log4j version 2.24.0. Reference: https://logging.apache.org/log4j/2.x/manual/configuration.html#configuration-attribute-status

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@macfarla
log4j: replace status with level
4691483 
Signed-off-by: Sally MacFarlane <[email protected]>
jframe
jframe approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) January 8, 2025 02:56
@macfarla macfarla disabled auto-merge January 13, 2025 05:32
@macfarla macfarla enabled auto-merge (squash) January 13, 2025 05:32
@macfarla macfarla merged commit f8ad155 into Consensys:master Jan 13, 2025
6 checks passed
@macfarla macfarla deleted the log4j-status-level branch January 13, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @jframe