Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIS-5 contract naming changes #427

Merged
merged 7 commits into from
May 3, 2024
Merged

CIS-5 contract naming changes #427

merged 7 commits into from
May 3, 2024

Conversation

lassemoldrup
Copy link
Contributor

@lassemoldrup lassemoldrup commented Apr 26, 2024 •
edited
Loading

Purpose

Addresses #422 by renaming according to the issue.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemoldrup lassemoldrup marked this pull request as ready for review April 30, 2024 14:10
DOBEN
DOBEN approved these changes Apr 30, 2024
View reviewed changes
examples/cis5-smart-contract-wallet/src/lib.rs Outdated Show resolved Hide resolved
examples/cis5-smart-contract-wallet/src/lib.rs Outdated Show resolved Hide resolved
examples/cis5-smart-contract-wallet/src/lib.rs Outdated Show resolved Hide resolved
soerenbf
soerenbf approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @DOBEN, otherwise LGTM 😄

@lassemoldrup lassemoldrup merged commit 9a9ca2e into main May 3, 2024
153 checks passed
@lassemoldrup lassemoldrup deleted the cis5-naming-changes branch May 3, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

@soerenbf soerenbf soerenbf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassemoldrup @soerenbf @DOBEN