-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module client and smart contract module schema #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
force-pushed
the
parse-module-schema
branch
from
September 8, 2023 06:58
f079446
to
5ae5323
Compare
5 tasks
limemloh
changed the base branch from
smart-contract-module-client
to
rm-module
September 8, 2023 07:37
limemloh
force-pushed
the
parse-module-schema
branch
3 times, most recently
from
September 11, 2023 17:32
2c46cb3
to
41f8e10
Compare
limemloh
changed the title
Parsing of smart contract module schema
Module client and smart contract module schema
Sep 11, 2023
limemloh
force-pushed
the
parse-module-schema
branch
from
September 11, 2023 17:57
41f8e10
to
4ec9a31
Compare
soerenbf
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! Some minor things to consider:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #245
Closes #246
Changes
ModuleClient
module and type for interaction with a smart contract module deployed on chain.Energy
,BlockHash
,TransactionHash
,InitName
,ContractName
,Parameter
andAccountSequenceNumber
.getInstanceInfo
andcheckOnChain
on the generic contract clientContract
.getEmbeddedModuleSchema
for getting the module schema embedded into a smart contract module source.parseRawModuleSchema
for parsing the module schema bytes.Checklist
hard-to-understand areas.