Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send update instruction + Fix getBlockChainParameters #222

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Allow sending parameters updates with the gRPC client.

Changes

  • Added sendUpdateInstruction entrypoint to the gRPC client.
  • Added missing fields to getBlockChainParameters response.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@shjortConcordium shjortConcordium marked this pull request as ready for review July 14, 2023 11:52
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests (i.e. nodejs/test) fail with the addition to chain parameters due to type mismatch in expectedJsons.ts.

It would be nice if you could update the tests for nodejs/test/client.test.ts as well to ensure compatibility with both v1 and v2 api.

packages/common/src/GRPCClient.ts Outdated Show resolved Hide resolved
packages/common/src/types.ts Outdated Show resolved Hide resolved
@shjortConcordium
Copy link
Contributor Author

shjortConcordium commented Sep 4, 2023

Tests (i.e. nodejs/test) fail with the addition to chain parameters due to type mismatch in expectedJsons.ts.

It would be nice if you could update the tests for nodejs/test/client.test.ts as well to ensure compatibility with both v1 and v2 api.

They don't fail for me 🤔
(Maybe it has been fixed elsewhere in the mean time)

Okay I didn't rebuild common, that is why it didn't failed. 🙃

But I've fixed it now.

I didn't update the v1 tests, but fixed the types (the keys are not in the chainParameters for v1)

packages/common/CHANGELOG.md Outdated Show resolved Hide resolved
@shjortConcordium shjortConcordium merged commit d28cbe0 into main Sep 5, 2023
9 checks passed
@shjortConcordium shjortConcordium deleted the sendUpdateInstruction branch September 5, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants