-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send update instruction + Fix getBlockChainParameters #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests (i.e. nodejs/test
) fail with the addition to chain parameters due to type mismatch in expectedJsons.ts
.
It would be nice if you could update the tests for nodejs/test/client.test.ts
as well to ensure compatibility with both v1 and v2 api.
6f9cfeb
to
2acedfc
Compare
Okay I didn't rebuild common, that is why it didn't failed. 🙃 But I've fixed it now. I didn't update the v1 tests, but fixed the types (the keys are not in the chainParameters for v1) |
Purpose
Allow sending parameters updates with the gRPC client.
Changes
sendUpdateInstruction
entrypoint to the gRPC client.getBlockChainParameters
response.Checklist
hard-to-understand areas.