Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect better #280

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Reconnect better #280

merged 6 commits into from
Oct 19, 2023

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Oct 19, 2023

Purpose

If a request fails due to timeout or resource exhaustion do not drop the connection and reconnect.

This helps in cases of high load which previously led to a lot of reconnects.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CHANGELOG is missing.

src/Concordium/Client/Runner/Helper.hs Show resolved Hide resolved
src/Concordium/Client/GRPC2.hs Show resolved Hide resolved
src/Concordium/Client/GRPC2.hs Show resolved Hide resolved
@abizjak abizjak merged commit 4632190 into main Oct 19, 2023
2 checks passed
@abizjak abizjak deleted the reconnect-better branch October 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants