Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the format flag when importing an account #277

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

MilkywayPirate
Copy link
Contributor

@MilkywayPirate MilkywayPirate commented Sep 19, 2023

Purpose

Address #253

By default show the format option when importing an account.

This change will make it easier to import accounts generated as part of genesis creation.
Normally this flag is not used by users since they get their account by going through an idp via one of the wallets.

However there will soon be a tool available for running a local chain with a custom genesis.
In this scenario it's desirable to make it easy for users to import their generated accounts into the client so the client
is easy to use with their new custom chain.

Note also that the default value mobile is the same as before, so the user does not have to explicitly provide this flag if importing a mobile backup.

Changes

Remove the SHOW_ALL_OPTS env variable and by default show all possible options at all times.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to issue #253

But note that this isn't really solving the issue. Users don't read command line documentation.

ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
@MilkywayPirate
Copy link
Contributor Author

Please link to issue #253

But note that this isn't really solving the issue. Users don't read command line documentation.

Nice. Thanks. I somehow missed that issue.

@MilkywayPirate MilkywayPirate merged commit 650e6c3 into main Sep 19, 2023
2 checks passed
@MilkywayPirate MilkywayPirate deleted the show-all-options branch September 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants