Add create account pages #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
force-pushed
the
x-create-account
branch
from
a2e4be8
to
370efa6
Compare
soerenbf
reviewed
Nov 12, 2024
I did an attempt of it in this PR |
soerenbf
previously approved these changes
Nov 13, 2024
soerenbf
dismissed
their stale review
Found something in other PR that belongs here
soerenbf
reviewed
Nov 13, 2024
There was a problem hiding this comment.
If I attempt to create an account with an expired identity, I don't get any feedback that the account creation did not succeed.
In the current wallet I get an error (an obscure bad UX RPC error message, but hey.. it's something?). I think it would make sense to filter out identities that cannot be used for account creation.
soerenbf
reviewed
Nov 14, 2024
packages/browser-wallet/src/popup/popupX/pages/CreateAccount/CreateAccount.tsx
Outdated
Show resolved
Hide resolved
soerenbf
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement account creation pages, i.e. select identity and confirm.
Some details that I have left out and will address in a future PR are: