Fix bug in check for EU country set

packages/browser-wallet/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 -   A button in settings that opens the wallet in fullscreen mode in a tab.
 
+### Fixed
+
+-   An issue where some proof requests for nationality or country of residence would be misintrepreted as asking whether in the EU or not.
+
 ## 1.4.2
 
 ### Fixed

packages/browser-wallet/src/popup/pages/IdProofRequest/DisplayStatement/utils.ts

@@ -22,8 +22,8 @@ export type SecretStatement = Exclude<AtomicStatement, RevealStatement>;
 export const getYearFromDateString = (ds: string): number => Number(ds.substring(0, 4));
 const formatDateString = (ds: string): string => `${ds.substring(0, 4)}-${ds.substring(4, 6)}-${ds.substring(6)}`;
 
-const isEuCountrySet = (countries: string[]) =>
-    countries.length === EU_MEMBERS.length && countries.every((n) => EU_MEMBERS.includes(n));
+export const isEuCountrySet = (countries: string[]) =>
+    countries.length === EU_MEMBERS.length && EU_MEMBERS.every((euCountry) => countries.includes(euCountry));
 
 const getTextForSet =
     <T extends (...args: any) => any>(t: T, statement: MembershipStatement | NonMembershipStatement) =>

packages/browser-wallet/test/id-proof-util.test.ts

@@ -0,0 +1,16 @@
+import { EU_MEMBERS } from '@concordium/web-sdk';
+import { isEuCountrySet } from '../src/popup/pages/IdProofRequest/DisplayStatement/utils';
+
+test('not eu country set if only one country in set', () => {
+    const countries = 'DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK,DK'.split(',');
+
+    const isEu = isEuCountrySet(countries);
+
+    expect(isEu).toBeFalsy();
+});
+
+test('eu country set returns true when checking if eu country set', () => {
+    const isEu = isEuCountrySet(EU_MEMBERS);
+
+    expect(isEu).toBeTruthy();
+});