Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose legacy GRPC client from common-sdk #431

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Feb 2, 2024

Purpose

Re-expose legacy GRPC client, this time from @concordium/common-sdk.

I verified that this does not trigger requesting any WASM.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Feb 2, 2024
Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doesn't seem to load the wasm. (Though it does increase the inject.ts size by 1.3mb 🤔)

@soerenbf
Copy link
Collaborator Author

soerenbf commented Feb 5, 2024

LGTM, doesn't seem to load the wasm. (Though it does increase the inject.ts size by 1.3mb 🤔)

That is weird, did not notice this. Will have an additional look.

EDIT: Tried comparing the size of inject.js for:

  • v1.3.0 tag (just some version which exported ConcordiumGRPCClient from the legacy UMD file) - 3.3mb
  • expose-legacy-grpc-client branch: 600kb

So overall a good result compared to the old version. Of course it will not be comparable to the inject that did not really depend on the SDK except for types 😉

v1.3.0
Screenshot 2024-02-05 at 08 58 14

expose-legacy-grpc-client
Screenshot 2024-02-05 at 08 58 29

How did you get 1.3mb?

Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get 1.3mb?

I think it's my bad, I just checked with build:dev. 🙃
(With prod it's 600kb vs 300kb (expose vs main))

@soerenbf soerenbf merged commit 7df31a0 into main Feb 6, 2024
4 checks passed
@soerenbf soerenbf deleted the expose-legacy-grpc-client branch February 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants