Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new transaction fromJSON and toJSON #416

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Use new transaction fromJSON and toJSON #416

merged 5 commits into from
Feb 13, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Implements the changes described in Concordium/concordium-node-sdk-js#307.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

soerenbf
soerenbf reviewed Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@soerenbf soerenbf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait with merging this until the web-sdk version containing the functionality required is officially released (which I guess is also why you still have it in review?).

Otherwise looks good! 🙂

packages/browser-wallet/src/shared/utils/payload-helpers.ts Show resolved Hide resolved
@lassemoldrup lassemoldrup marked this pull request as ready for review February 2, 2024 15:18
soerenbf
soerenbf approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lassemoldrup lassemoldrup merged commit 5faa087 into main Feb 13, 2024
4 checks passed
@lassemoldrup lassemoldrup deleted the transaction-json-serialization branch February 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

@soerenbf soerenbf Awaiting requested review from soerenbf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassemoldrup @soerenbf @shjortConcordium