Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of instanceof when sanitizing wallet-api inputs #404

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Remove usage of instanceof when sanitizing wallet-api inputs #404

merged 7 commits into from
Nov 7, 2023

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Fix potential errors caused by version mismatch in SDK version with dApps.

Changes

  • Remove usage of instanceOf when sanitizing wallet-api inputs.
  • Use AccountAddress in piggybank.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@shjortConcordium shjortConcordium merged commit 3d505e0 into main Nov 7, 2023
4 checks passed
@shjortConcordium shjortConcordium deleted the fix-sanitize branch November 7, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhoj orhoj orhoj approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shjortConcordium @orhoj