Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display pending verifiable credentials #348

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Display pending verifiable credentials.

Changes

  • Add session storage for verifiable credential metadata.
  • Use session stored metadata if credentialEntry is missing.
  • Catch some errors in VC hooks.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj
Copy link
Contributor

orhoj commented Aug 24, 2023

If I press the pending credential to see its details, then I get shown blank content. Probably because it expects something to load that won't load until it is on-chain.

@orhoj orhoj assigned shjortConcordium and unassigned orhoj Aug 24, 2023
@shjortConcordium shjortConcordium merged commit 88e053b into feature/web3-id Aug 24, 2023
4 checks passed
@shjortConcordium shjortConcordium deleted the show-pending-verifiable-credential branch August 24, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants