Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for tls, grafana variable syntax, victoriametrics and the check_nwc_health-interface.php template #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jstark1
Copy link

@jstark1 jstark1 commented Oct 25, 2024

This patch skips TLS checks to the database, to prevent this error:

histou_victoriametrics_ssl_error

@jstark1 jstark1 changed the title don't verify tls connections to the database Fixes for tls, grafana variable syntax, victoriametrics and the check_nwc_health-interface.php template Oct 30, 2024
@jstark1
Copy link
Author

jstark1 commented Oct 30, 2024

The patches should fix ConSol-Monitoring/omd#206

@sni
Copy link

sni commented Oct 30, 2024

could you explain your changes a little bit?

@jstark1
Copy link
Author

jstark1 commented Oct 30, 2024

Sure,

  1. PHP default checks the TLS Certificates. If we use InfluxDB or Victoriametrics in SSL mode, Histou fails with the TLS error above. One option is to use valid Certificates and correct Hostnames/IPs and give PHP and Grafana a truststore to check the validity. In my Change, we simply bypass the certificate checks, like the Grafana datasources.
  2. If we use Grafana dashboards with dynamic variables, like the check_nwc_health-interface.php template, we need to bypass the default Grafana template quoting, to use values correct values in the graph lookups with the new template ${var:raw}
  3. The InfluxDB Dashboard works now, in the third commit I checked the same check_nwc_health-interface.php dashboard with Victoriametrics. I don't know if and how it worked before, so I replaced the label lookup (https://docs.victoriametrics.com/url-examples/#apiv1labels)
  4. The last 3 commits are GUI polish and a logic error in the check_nwc_health-interface.php template

The Pull Request sni/Thruk#1404 are also on the GUI side the hide the new grafana variable syntax

I hop this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants