Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pagenator in list item to avoid 1000 limit #178

Merged
merged 3 commits into from
Sep 1, 2023
Merged

use pagenator in list item to avoid 1000 limit #178

merged 3 commits into from
Sep 1, 2023

Conversation

shokakucarrier
Copy link
Member

No description provided.

ligangty
ligangty reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But for sure maybe we need to add unit tests later.

charon/storage.py Outdated Show resolved Hide resolved
@shokakucarrier shokakucarrier merged commit 281cfd8 into Commonjava:main Sep 1, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligangty ligangty ligangty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shokakucarrier @ligangty