Skip to content

Commit

Permalink
Merge pull request #275 from ligangty/maven
Browse files Browse the repository at this point in the history
chore: fixed a api doc and added some comments
  • Loading branch information
ligangty authored Sep 24, 2024
2 parents 0064e42 + c2a9957 commit 28902ad
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions charon/pkgs/maven.py
Original file line number Diff line number Diff line change
Expand Up @@ -996,8 +996,8 @@ def _generate_metadatas(
what we should do here is:
* Scan and get the GA for the poms
* Search all poms in s3 based on the GA
* Use searched poms and scanned poms to generate
maven-metadata to refresh
* Use searched pomsto generate maven-metadata
to refresh
"""
ga_dict: Dict[str, bool] = {}
logger.debug("Valid poms: %s", poms)
Expand All @@ -1007,6 +1007,8 @@ def _generate_metadatas(
logger.debug("G: %s, A: %s", g, a)
g_path = "/".join(g.split("."))
ga_dict[os.path.join(g_path, a)] = True
# Note: here we don't need to add original poms, because
# they have already been uploaded to s3.
all_poms = []
meta_files = {}
for path, _ in ga_dict.items():
Expand Down

0 comments on commit 28902ad

Please sign in to comment.