Add security standard: No use of requests to download Python code/libraries for use in modules
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibraries for use in modules This is in the same spirit as the restriction of not allowing `pip` calls via `subprocess` calls. The reason this is being suggested now is due to this observation of a module in the ComfyUI registry doing just this - using `requests` to download Python code from a separate repository and then write those files and then in the same module usage, import that library. This is dangerous because it is unvetted / unauditable code. https://github.com/1038lab/ComfyUI-OmniGen/blob/4f9d6a945e3fa7aaf4485c4e7c5292c9b4826ab7/ailab_OmniGen.py#L76
|
@teward Would you be willing to write an RFC for this in https://github.com/Comfy-Org/rfcs? |
Yep, just make sure I hiave access to the RFCs repository so I can submit. Or if you need me to do a PR for that I can. It'll be after work though so gotta give me some time to get to it. |
|
@christian-byrne Comfy-Org/rfcs#12 FYI refer to Discord pings though we need an RFC ID reservation program / tooling if we want to adopt this because otherwise we'll run into RFC numbering conflicts potentially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in the same spirit as the restriction of not allowing
pipcalls viasubprocesscalls.The reason this is being suggested now is due to this observation of a module in the ComfyUI registry doing just this - using
requeststo download Python code from a separate repository and then write those files and then in the same module usage, import that library. This is dangerous because it is unvetted / unauditable code. https://github.com/1038lab/ComfyUI-OmniGen/blob/4f9d6a945e3fa7aaf4485c4e7c5292c9b4826ab7/ailab_OmniGen.py#L76