Implement boilerplate code for tracking events with Mixpanel #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! love the wrapper style, we should have an option to track the first time running comfy-cli and prompt user to opt out of tracking. |
|
As for whether it was the first time running, I believe @ltdrdata is adding a config to keep track of comfy-cli level of meta data (e.g. the most recent repo that has been run through comfy-cli). Ideally the comfy-cli config is done using similar singleton class as MetadataManager or EnvChecker, so it can be used systematically in multiple places. |
Yeah left out as a TODO, I'll handle that in a follow-up PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.