Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pypi check_for_updates from commands where it halts offline execution #176

Closed
wants to merge 3 commits into from

Conversation

jason-weirather
Copy link

Checking the version of comfy-cli in commands where internet-access is not necessary, such as comfy launch and comfy env causes comfy-cli to hang in a docker container (or offline) environment.

I opened an issue to describe this
#175

This PR removes just those calls to check_for_updates() that ping pypi each time a comfy launch is run or a comfy env is checked where offline operation can otherwise work perfectly.

@robinjhuang
Copy link
Member

Can we change the check_for_update function to fail gracefully instead?

@jason-weirather
Copy link
Author

Can we change the check_for_update function to fail gracefully instead?

I think thats a reasonable solution if its very fast to fail gracefully. Otherwise we will have every command hanging for seconds while it waits trying to have a conversation with the pypi servers, and that would reduce performance in some deployments.

@jason-weirather
Copy link
Author

I've submitted a new PR following @robinjhuang suggestion to add a timeout and fail quietly.

#183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants