Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy<2 override #170

Closed
wants to merge 3 commits into from
+8 −1
Closed

numpy<2 override #170

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
846a5c5
add a temporary override that limits numpy<2
telamonian Aug 30, 2024
56c2512
limit numpy<2 override to windows only
telamonian Aug 30, 2024
fd85b53
fix typo in numpy<2 override
telamonian Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion comfy_cli/uv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
from typing import Any, Optional, Union, cast

from comfy_cli import ui
from comfy_cli.constants import GPU_OPTION
from comfy_cli.constants import GPU_OPTION, OS
from comfy_cli.typing import PathLike
from comfy_cli.utils import get_os


def _run(cmd: list[str], cwd: PathLike, check: bool = True) -> subprocess.CompletedProcess[Any]:
Expand Down Expand Up @@ -52,6 +53,7 @@ class DependencyCompiler:
# ensure usage of {gpu} version of pytorch
--extra-index-url {gpuUrl}
torch
torchaudio
torchsde
torchvision
"""
Expand Down Expand Up @@ -368,6 +370,11 @@ def make_override(self):
f.write(DependencyCompiler.overrideGpu.format(gpu=self.gpu, gpuUrl=self.gpuUrl))
f.write("\n\n")

# TODO: remove numpy<2 override once torch is compatible with numpy>=2
if get_os() == OS.WINDOWS:
f.write("numpy<2\n")
f.write("\n\n")

completed = DependencyCompiler.Compile(
cwd=self.cwd,
reqFiles=self.reqFilesCore,
Expand Down
Loading