Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Symptom
Some collectors didn't seem to synchronise a date(time) field anymore (since 1.4.0)
Reproduction procedure
Cause
itop-data-collector-base 1.4.0 introduced a new setting with a default value which wasn't the same as the previous behaviour.
Proposed solution
Use the previous behaviour as the default value for the
date_format
setting. The other change provides useful debug data even when no errors detected on the import, like:Checklist before requesting a review