Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default date_format #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hipska
Copy link
Collaborator

@Hipska Hipska commented Jun 13, 2024

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? #45
Type of change? Bug fix

Symptom

Some collectors didn't seem to synchronise a date(time) field anymore (since 1.4.0)

Reproduction procedure

  1. With teemip-ip-discovery-collector 3.1.3
  2. Run a collection + synchro
  3. Then observe in iTop that the Last discovery date isn't updated.

Cause

itop-data-collector-base 1.4.0 introduced a new setting with a default value which wasn't the same as the previous behaviour.

Proposed solution

Use the previous behaviour as the default value for the date_format setting. The other change provides useful debug data even when no errors detected on the import, like:

0: Wrong format for DATETIME column 3: ‘2024-06-13 14:05:09’ does not match the expected format: ‘Y-m-d’ (column skipped)

Checklist before requesting a review

  • I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant