Replace jQuery show animation with CSS animation in sidebar #11044
Conversation
Cwiiis
force-pushed
the
private/cwiiis/sidebar-css-animation
branch
2 times, most recently
from
a9ce24a to
f669d30
Compare
|
Looking into each failure - I observe correct behaviour, I expect some tests are breaking because they ran and completed while the sidebar was still expanding, which would change horizontal scroll positions. The sidebar now doesn't cause the document to go through a series of resizes, so some adjustments need to be made - making them now. |
|
I've fixed the related failures, there's one more failure here that I believe is an intermittent ("Moving between paragraphs" in |
The sidebar-showing animation was relying on jQuery, which just animates the width/height properties (absolutely killer for performance). Replace this with a CSS animation. Note, the animation isn't identical; previously the document size would animate, but this now just snaps to the destination size. Animating document size changes is unlikely to be viable any time soon, but we may want to consider some kind of 2-part move + resize animation. Signed-off-by: Chris Lord <[email protected]> Change-Id: I68eb16e9eff9a3a9601f3f903f9edb25b97a56cd
Cwiiis
force-pushed
the
private/cwiiis/sidebar-css-animation
branch
from
f669d30 to
f4f248b
Compare
| ceHelper.checkPlainContent('green red'); | ||
| ceHelper.moveCaret('left', '', 4); | ||
| ceHelper.checkCaretPosition(5); | ||
| helper.getBlinkingCursorPosition('P2'); | ||
| cy.wait(800); |
There was a problem hiding this comment.
Not happy about the size of these waits, but these seemed to be the minimum values to get this test to pass consistently locally. Both of these are masking a real bug, I can easily replicate the failure with manual inputs and it doesn't mirror the behaviour in desktop Writer. This seems very similar to #10585 and I wouldn't be surprised if the underlying reason is basically the same.
There was a problem hiding this comment.
This works and i guess increases the rendering performance.
For the visual changes, i would also inform @pedropintosilva :) It'd be good to have his opinion.
Thank you for the improvement.
The sidebar-showing animation was relying on jQuery, which just animates the width/height properties (absolutely killer for performance). Replace this with a CSS animation. Note, the animation isn't identical; previously the document size would animate, but this now just snaps to the destination size. Animating document size changes is unlikely to be viable any time soon, but we may want to consider some kind of 2-part move + resize animation.
Change-Id: I68eb16e9eff9a3a9601f3f903f9edb25b97a56cd
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay