Incremental typescript conversion of core/Util.js #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Jan 24, 2025
Signed-off-by: Dennis Francis <[email protected]> Change-Id: If0b099eceab932b4a52ce0a68269fcd7d810bd9f
inside L.Util.requestAnimFrame unconditionally as we have already assuming the availability of window.requestAnimationFrame inside canvas-section container. Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ifdf885452135346e1df5f3196d49f76b8d1f983a
Signed-off-by: Dennis Francis <[email protected]> Change-Id: If77f50074b002c8a7566daf61cac3b14474aa838
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I31b5328976c6b46a62542e5b1b69bc1148893db9
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I07fb6b479c93789f773857e15041c8c35ee8328a
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I56f870121ed2141f3ca3bb234531505d45f624df
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I18311f09a63e793fb58b4de44c0f6c58c69f0883
dennisfrancis
force-pushed
the
private/dennisf/typescript-conversion
branch
from
99223b2 to
eefb34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript conversion of core/Util.js.
Summary
This PR contains an incremental approch to typescript conversion of core/Util.js. The goal is to remove L.Util as soon as the usages of its legacy leaflet js content is removed and rename core/CoolUtil.ts to core/Util.ts.
This PR also includes one functional change of unconditionally using window.requestAnimationFrame inside the wrapper L.Util.requestAnimFrame() as we are assuming the availability of window.requestAnimationFrame in canvas section container anyway.
TODO
[x] mocha tests for testable functions in CoolUtil.js
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay