Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocha: store the compiled js files in a separate folder away from the typescript files #11008

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dennisfrancis
Copy link
Member

@dennisfrancis dennisfrancis commented Jan 24, 2025

Store the compiled mocha js files in a separate folder away from the source typescript files.

Change-Id: Ibc1ecd263f53b2e6db736d9c6f1330998d4e2bf8

  • Target version: master

Summary

Store the compiled mocha js files in a separate folder away from the source typescript files.

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@dennisfrancis dennisfrancis requested a review from vmiklos January 24, 2025 09:48
Copy link
Contributor

@vmiklos vmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cypress tests, such generated files are under cypress_test/workdir/, would it make sense to go with the same "workdir" name here for consistency?

Ignoring a dir named "js" is a bit strange when some of our actual code is also in JS. What do you think?

folder away from the typescript files.

Signed-off-by: Dennis Francis <[email protected]>
Change-Id: Ibc1ecd263f53b2e6db736d9c6f1330998d4e2bf8
@dennisfrancis dennisfrancis force-pushed the private/dennisf/mocha-compiled-js branch from 540f67f to 1a18fae Compare January 27, 2025 10:18
Copy link
Contributor

@vmiklos vmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks!

Nit: in general, feel free to ask such code reviews from @quikee , we try to distribute the workload . :-)

@vmiklos vmiklos merged commit 841b69f into master Jan 27, 2025
14 checks passed
@vmiklos vmiklos deleted the private/dennisf/mocha-compiled-js branch January 27, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants