Notebookbar: main-nav: Fix last child being glued to the edge #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the .main-nav's width had bigger width than the webview due to borders not being factored in. This was particular visible for integrators that have the close button toggled off and that have no "EnableShare" where the last sidebar icon was "glued" the right edge of the web view. Cases where this is possible to test: - Using the make run Edit mode urls in Tabbed view - Places where Collabora Online is integrated with close and share buttons. Example: Moddle Signed-off-by: Pedro Pinto Silva <[email protected]> Change-Id: Ie189ed780080cda69d3d41e425a047c45d0e69e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the .main-nav's width had bigger width than the
webview due to borders not being factored in. This was particular
visible for integrators that have the close button toggled off and
that have no "EnableShare" where the last sidebar icon was "glued" the
right edge of the web view.
Cases where this is possible to test:
share buttons. Example: Moddle
Signed-off-by: Pedro Pinto Silva [email protected]
Change-Id: Ie189ed780080cda69d3d41e425a047c45d0e69e9