Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries to better support MM v6/v7 #78

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

availchet
Copy link
Contributor

@availchet availchet commented Mar 12, 2023

Summary

  • Changes and fixes to run on Mattermost v6 and v7.
  • Upgrade libraries and tooling in package.json and go.mod to support MM v6+.
  • Changes in both webapp and server code to make use of new APIs.
  • Upgrade to use new file backend APIs in MM and Test filestore/s3 connection whenever configuration changes.

Related Issues

Test Environment

  • Tested in the latest version of Mattermost developer codebase.

Mattermost Team Edition
Mattermost Version: dev
Database Schema Version: 104
Database: postgres

Plugin Download Link for testing

Checklist

  • Ran make check-style to check for style errors (required for all pull requests).
  • Ran make test to ensure unit and component tests passed.

* 'master' of github.com:availchet/collabora-mattermost:
  Enable codeql security-and-quality for pull-requests
  Misc Fixes
@availchet availchet changed the title WIP: Upgrade to MM v6 Upgrade libraries to better support MM v6/v7 Mar 13, 2023
@availchet availchet marked this pull request as ready for review March 13, 2023 15:36
@availchet
Copy link
Contributor Author

availchet commented Mar 13, 2023

@kendy @mrkara @wget @timar @pedropintosilva
Could I get some reviews on this, please?

P.S. It seems that Jenkins is failing on the npm install step, maybe it's some caching issue.

@wget
Copy link
Collaborator

wget commented Mar 13, 2023

@availchet Sure. Please let me know which Go and nodejs+npm versions you used for this?

If I can build it, I'll merge your PR and deploy it on a Mattermost deployment I have for a SMB IT I manage in order to test it at a larger scale :).

@availchet
Copy link
Contributor Author

@wget These are the ones I am using:

$ node -v
v16.13.1

$ npm -v                             
8.1.2

$ go version
go version go1.20.1 darwin/amd64

@jprusch
Copy link

jprusch commented Mar 13, 2023

I follow this discussion and can confirm that the test version is working like a charm with Mattermost 7.8.0:

@scholzri
Copy link

scholzri commented Apr 3, 2023

@availchet
Hello,
thank you so much for your work, we are finally able to use this mattermost integration on an up-to-date instance! :)
As far as I understand, with the current implementation it is not possible to use the integration in the desktop and mobile apps, because there is no context menu for files what so ever. Would it be possible to add support for those clients? Maybe through a link based approach, that automatically generates a link for a given file, which redirects you to the collabora web app in the browser?

Again, thank you for your hard work!
Greetings!

@jprusch
Copy link

jprusch commented Apr 3, 2023

Hi @AdmerStroh
the collabora mattermost implementation is realized by a plugin. AFAIK plugins are not supported on the mobile app. The desktop application works fine for us with this version:

https://drive.google.com/file/d/1Yp5I5S4Ma_P-YcSMDtkcxKGAwa8FdOuo/view?usp=sharing

Creating a new file is realized thru the attachment symbol when writing a new message. Permissions are supported.

@pedropintosilva pedropintosilva requested a review from wget April 5, 2023 09:49
@timar timar closed this Jun 25, 2023
@timar timar reopened this Jun 25, 2023
@R-Hammer
Copy link

Any progress here? Looking forward to it!

@Rash419 Rash419 self-requested a review July 8, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants