Code

Issue #83: Refactor wopi controller#84

Code

Merged

AaronGilMartinez merged 70 commits intomainCollaboraOnline/collabora-drupal:mainfrom issue-83-refactor-wopi-controllerCollaboraOnline/collabora-drupal:issue-83-refactor-wopi-controllerCopy head branch name to clipboardJan 20, 2025

+962-235

Commits

Commits on Jan 17, 2025

• Issue 83: Add some trailing commas on multi-line argument lists.

  donquixote

  committed
  26b6df2

  Copy full SHA for 26b6df2

• Issue 83: Return 404 instead of 403 for media not found.

  donquixote

  committed
  1df2c48

  Copy full SHA for 1df2c48

• Issue 83: Fix ExceptionWopiSubscriber service by adding autoconfigure in services.yml, and setting Content-Type header.

  Show description for aa7d28a
  donquixote

  committed
  aa7d28a

  Copy full SHA for aa7d28a

• Issue 83: Refactor ExceptionWopiSubscriber, introducing local vars.

  donquixote

  committed
  cfca92f

  Copy full SHA for cfca92f

• Issue 83: Use wildcard loading for media entity in WopiController, but keep 403.

  Show description for 9efebde
  donquixote

  committed
  9efebde

  Copy full SHA for 9efebde

• Issue 83: Pass the media entity directly to verifyTokenForMedia().

  donquixote

  committed
  3ec3c87

  Copy full SHA for 3ec3c87

• Issue 83: Always fail if token is missing.

  donquixote

  committed
  d431553

  Copy full SHA for d431553

• Issue 83: Remove pointless local var $returnCode.

  donquixote

  committed
  0ac761b

  Copy full SHA for 0ac761b

• Issue 83: Centralize the call to verifyTokenForMedia().

  donquixote

  committed
  bc26320

  Copy full SHA for bc26320

• Issue 83: Centralize the user loading.

  donquixote

  committed
  a451d9a

  Copy full SHA for a451d9a

• Issue 83: Centralize the file loading.

  donquixote

  committed
  f00e9fe

  Copy full SHA for f00e9fe

• Issue 83: Centralize the can_write check.

  donquixote

  committed
  3e07847

  Copy full SHA for 3e07847

• Issue 83: Drop pointless local var $mimetype.

  donquixote

  committed
  13e7af9

  Copy full SHA for 13e7af9

• Issue 83: Extract buildSaveReason() from wopiPutFile().

  donquixote

  committed
  7516055

  Copy full SHA for 7516055

• Issue 83: Rename $payload -> $response_data.

  donquixote

  committed
  2b12a09

  Copy full SHA for 2b12a09

• Issue 83: Rename $jsonPayload -> $response_json.

  donquixote

  committed
  ba48462

  Copy full SHA for ba48462

• Issue 83: Use JsonResponse.

  donquixote

  committed
  0e4d406

  Copy full SHA for 0e4d406

• Issue 83: Return the response directly, drop the local var.

  donquixote

  committed
  6b33eea

  Copy full SHA for 6b33eea

• Issue 83: Don't forget to switch back the account.

  donquixote

  committed
  5063f45

  Copy full SHA for 5063f45

• Issue 83: Don't switch account in wopiGetFile().

  Show description for e9f85b7
  donquixote

  committed
  e9f85b7

  Copy full SHA for e9f85b7

• Issue 83: Don't switch account in wopiPutFile().

  donquixote

  committed
  b5d132d

  Copy full SHA for b5d132d

• Issue 83: Drop local vars in buildSaveReason().

  donquixote

  committed
  99a6dde

  Copy full SHA for 99a6dde

• Issue 83: Enhance reporting on failing test in assertJsonResponse().

  donquixote

  committed
  6260a94

  Copy full SHA for 6260a94

• Issue 83: Rename a variable to $new_file.

  donquixote

  committed
  8bb0015

  Copy full SHA for 8bb0015

• Issue 83: Properly format the log message on save timestamp conflict.

  donquixote

  committed
  b11fa7f

  Copy full SHA for b11fa7f

• Issue 83: Rename a variable to $wopi_changed_time in WopiControllerTest.

  donquixote

  committed
  2752e17

  Copy full SHA for 2752e17

• Issue 83: Assert the log message in WopiControllerTest::testWopiPutFileConflict().

  donquixote

  committed
  3abd424

  Copy full SHA for 3abd424

• Issue 83: Extract checkSaveTimestampConflict() from wopiPutFile().

  donquixote

  committed
  9ca30c5

  Copy full SHA for 9ca30c5

• Issue 83: Assert that the file is replaced in wopiPutFile().

  donquixote

  committed
  8bfb2fe

  Copy full SHA for 8bfb2fe

• Issue 83: Assert that file uri changes on save.

  donquixote

  committed
  4197dd9

  Copy full SHA for 4197dd9

• Issue 83: Extract callbackTestWopiPutFile() from testWopiPutFile().

  donquixote

  committed
  b65b72d

  Copy full SHA for b65b72d

• Issue 83: Remove a pointless line in callbackTestWopiPutFile().

  donquixote

  committed
  d76b0ef

  Copy full SHA for d76b0ef

• Issue 83: Convert the closure to regular method doTestWopiPutFile().

  donquixote

  committed
  7ced738

  Copy full SHA for 7ced738

• Issue 83: Inline $expected_response_data.

  donquixote

  committed
  a6624dc

  Copy full SHA for a6624dc

• Issue 83: Assert the media revision log message.

  donquixote

  committed
  02d7b32

  Copy full SHA for 02d7b32

• Issue 83: Assert the saved file content.

  donquixote

  committed
  be8534c

  Copy full SHA for be8534c

• Issue 83: Rename a variable to $new_file_uri.

  donquixote

  committed
  25a33c2

  Copy full SHA for 25a33c2

• Issue 83: Rename $content -> $new_file_content in wopiPutFile().

  donquixote

  committed
  5011509

  Copy full SHA for 5011509

• Issue 83: Extract createNewFileEntity() from wopiPutFile().

  donquixote

  committed
  6542c97

  Copy full SHA for 6542c97

• Issue 83: Inline $owner_id in createNewFileEntity().

  donquixote

  committed
  916c4f3

  Copy full SHA for 916c4f3

• Issue 83: Always preserve the filename on save, don't check if old file exists.

  donquixote

  committed
  09c21f3

  Copy full SHA for 09c21f3

• Issue 83: Break a call and an array to multiple lines.

  donquixote

  committed
  6fd08cc

  Copy full SHA for 6fd08cc

• Issue 83: Reorder statements in wopiPutFile().

  donquixote

  committed
  1580163

  Copy full SHA for 1580163

• Issue 83: Drop the $mtime variable, introduce DateTimeHelper::format().

  donquixote

  committed
  487524c

  Copy full SHA for 487524c

• Issue 83: Rename variables that hold timestamps, time strings or datetime objects.

  donquixote

  committed
  6900a3e

  Copy full SHA for 6900a3e

• Issue 83: Assert exact file uri on save.

  donquixote

  committed
  2d88e46

  Copy full SHA for 2d88e46

• Issue 83: Assert that file name does not change on save.

  donquixote

  committed
  e337cb7

  Copy full SHA for e337cb7

• Issue 83: Assert that file owner is set correctly on save.

  donquixote

  committed
  942ca91

  Copy full SHA for 942ca91

• Issue 83: Change log level to info.

  donquixote

  committed
  d0205ab

  Copy full SHA for d0205ab

• Issue 83: Introduce WopiControllerTest::assertOnlyLogMessage().

  donquixote

  committed
  bdff035

  Copy full SHA for bdff035

• Issue 83: Change the log message on save to provide more detail.

  donquixote

  committed
  bbf8ac9

  Copy full SHA for bbf8ac9

• Issue 83: Fix typo 'mesage' -> 'message'.

  donquixote

  committed
  6729442

  Copy full SHA for 6729442

• Issue 83: Add copyright in ExceptionWopiSubscriber.

  donquixote

  committed
  a6f26f2

  Copy full SHA for a6f26f2

• Issue 83: Assert that new file is permanent.

  donquixote

  committed
  682c073

  Copy full SHA for 682c073

• Issue 83: Test missing token.

  donquixote

  committed
  b850900

  Copy full SHA for b850900

• Issue 83: Check and test if file entity missing.

  donquixote

  committed
  176f315

  Copy full SHA for 176f315

• Issue 83: Check and test if file missing in filesystem.

  donquixote

  committed
  c217401

  Copy full SHA for c217401

• Issue 83: Test file size field value on save.

  donquixote

  committed
  22129d7

  Copy full SHA for 22129d7

• Issue 83: Rely on core to update the file size field value.

  donquixote

  committed
  ca665e4

  Copy full SHA for ca665e4

• Issue 83: Introduce CollaboraJwtKeyException, and clarify failure messages for jwt-related problems.

  donquixote

  committed
  50746d0

  Copy full SHA for 50746d0

• Issue 83: Introduce KernelTestLoggerTrait.

  donquixote

  committed
  04f2583

  Copy full SHA for 04f2583

• Issue 83: Assert core log messages in assertAccessDeniedResponse() and assertNotFoundResponse().

  donquixote

  committed
  de45fa1

  Copy full SHA for de45fa1

• Issue 83: Assert no log messages left in tearDown().

  donquixote

  committed
  00d1113

  Copy full SHA for 00d1113

• Issue 83: Assert log message in testBadToken().

  donquixote

  committed
  4e20afe

  Copy full SHA for 4e20afe

• Issue 83: Test JWT key missing or empty.

  donquixote

  committed
  d02baee

  Copy full SHA for d02baee

• Issue 83: Test the user picture in wopi file info response.

  donquixote

  committed
  830d47e

  Copy full SHA for 830d47e

• Issue 83: The 3 methods in WopiController don't need to be public.

  donquixote

  committed
  c713571

  Copy full SHA for c713571

• Issue 83: Test wopiPutFile() without write access.

  donquixote

  committed
  501c5f9

  Copy full SHA for 501c5f9

• Issue 83: Always check user write permission if token says 'wri'.

  donquixote

  committed
  ddc83e3

  Copy full SHA for ddc83e3

• Issue 83: Test missing write permission.

  donquixote

  committed
  b6b4a36

  Copy full SHA for b6b4a36