Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for CoolPreview formatter. #82

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add test for CoolPreview formatter. #82

merged 3 commits into from
Jan 16, 2025

Conversation

AaronGilMartinez
Copy link
Collaborator

No description provided.

brummbar
brummbar requested changes Jan 7, 2025
View reviewed changes
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
donquixote
donquixote reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@donquixote donquixote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some intermediate comments, will continue later.

templates/collabora-online-preview.html.twig Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
@AaronGilMartinez AaronGilMartinez force-pushed the test-field-formatter branch 2 times, most recently from ae43924 to 74f3e69 Compare January 10, 2025 16:13
donquixote
donquixote requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@donquixote donquixote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, i forgot to submit this review apparently!

tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Show resolved Hide resolved
tests/src/Kernel/CoolPreviewFormatterTest.php Outdated Show resolved Hide resolved
@donquixote donquixote merged commit 4cdb19b into main Jan 16, 2025
3 checks passed
@donquixote donquixote deleted the test-field-formatter branch January 16, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donquixote donquixote donquixote requested changes

@brummbar brummbar brummbar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronGilMartinez @donquixote @brummbar