Added only render YouTubeVideoEmbed in the view port #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dependency svelte-inview redource the load time massiv depends of the amount video released by the channels
|
test can't run since the project doesn't want package-lock.json be part of a pr, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce the load time massiv depends of the amount video released by the channels
What type of Pull Request is this?
What is the current behavior?
Load all images/stuff of all videos of all channels in the list -> result massiv load/cpu time
What is the new behavior?
Just rendering the most relevant videos,
when scrolling down more get loaded (since they are near the view port)
Other information
add dependency svelte-inview
i try to keep pr small/focused,
so i didn't added a default height/width --> the scroll bar is "jumping" when scrolling down
also the option for svelte-inview could maybe optimize