Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJs Deployment with Caprover and Github Actions #60

Merged
merged 44 commits into from
Nov 9, 2023

Conversation

smyja
Copy link
Contributor

@smyja smyja commented Jul 6, 2023

this resolves #55

@KTom101
Copy link
Collaborator

KTom101 commented Jul 7, 2023

@smyja Thanks for submitting a draft. Don't forget to hit the "Ready to review" button when you're ready.

@smyja smyja marked this pull request as ready for review July 9, 2023 09:49
@smyja
Copy link
Contributor Author

smyja commented Jul 13, 2023

@smyja Thanks for submitting a draft. Don't forget to hit the "Ready to review" button when you're ready.

I have done that.

@yangc95 yangc95 added the status: under review Issue or PR is currently being reviewed label Jul 14, 2023
@yangc95 yangc95 self-assigned this Jul 14, 2023
@smyja
Copy link
Contributor Author

smyja commented Aug 8, 2023

@yangc95 any update on this?

@yangc95
Copy link
Collaborator

yangc95 commented Aug 30, 2023

@yangc95 any update on this?

@smyja Thanks for your patience with this process and keeping an eye out for updates. As this is a longer format, this review process may take some time.

I will be fact-checking and provide feedback by EoW.

In the meantime, if you're open to working on something else within this repo, feel free to!

@smyja
Copy link
Contributor Author

smyja commented Aug 30, 2023

@yangc95 any update on this?

@smyja Thanks for your patience with this process and keeping an eye out for updates. As this is a longer format, this review process may take some time.

I will be fact-checking and provide feedback by EoW.

In the meantime, if you're open to working on something else within this repo, feel free to!

Great, I want to work on this

@yangc95
Copy link
Collaborator

yangc95 commented Aug 30, 2023

Great, I want to work on this

Yeah, go for it! I left a comment relating to that on its own thread.

Copy link
Collaborator

@yangc95 yangc95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smyja In addition, the error is occurring because app-market.png is too large 😮 <1 MB would be good!

smyja and others added 16 commits October 21, 2023 14:42
This reverts commit 1f8145e.
@smyja
Copy link
Contributor Author

smyja commented Oct 21, 2023

@smyja While you're continuing with @yangc95 changes, I've added some additional edits paying particular attention to how the software/tools used are named. I know it can be quite tedious but it's a good convention to make sure they're written correctly.

Thanks, i have resolved it.

@KTom101
Copy link
Collaborator

KTom101 commented Oct 24, 2023

@smyja I see several comments need to be added still. Please let me know when you're done, thanks

@smyja
Copy link
Contributor Author

smyja commented Oct 24, 2023

@smyja In addition, the error is occurring because app-market.png is too large 😮 <1 MB would be good!

I have resolved it.

@smyja
Copy link
Contributor Author

smyja commented Oct 24, 2023

@smyja I see several comments need to be added still. Please let me know when you're done, thanks

Thanks,resolved.

@smyja smyja requested a review from KTom101 October 24, 2023 19:12
@smyja
Copy link
Contributor Author

smyja commented Nov 8, 2023

@KTom101 Good day, any update?

Copy link
Collaborator

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smyja I made some minor adjustments directly. We can put this out now.

@KTom101 KTom101 merged commit 15e42a4 into Codecademy:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Topic Idea] NextJs Deployment with Caprover and Github Actions
3 participants