Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Term Entry Issue #5476 #5538

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

danitellini
Copy link

Description

Summary of the Change:

  • Topic: C++ Unordered Map - bucket() Function
  • File Created: docs/content/cpp/concepts/unordered-map/terms/bucket/bucket.md
  • Description: Created a new Term Entry for the bucket() function in the C++ unordered_map container.

I created this entry to solve an issue for my Learn Git and GitHub course.

Issue Solved

Closes #5476

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Oct 21, 2024
@mamtawardhani mamtawardhani added c++ C++ entries new entry New entry or entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: under review Issue or PR is currently being reviewed labels Oct 21, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @danitellini. The entry is well written 😄

I've suggested a few changes, could you please review and modify them at your earliest convenience? Thank you! 😃

@danitellini
Copy link
Author

@mamtawardhani Reviewed, edited, and pushed!

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy docs @danitellini 😄

The entry looks good for a second round of review! 🚀

@danitellini
Copy link
Author

Is there something I'm supposed to be doing, or is there just a delay? 😅

@dakshdeepHERE dakshdeepHERE removed the status: under review Issue or PR is currently being reviewed label Nov 2, 2024
@danitellini
Copy link
Author

I think I fixed the check fail format:verify

@mamtawardhani
Copy link
Collaborator

Is there something I'm supposed to be doing, or is there just a delay? 😅

Hey @danitellini the entry looks fine, it will get merged in a day or two don't worry. 😃

@danitellini
Copy link
Author

It was failing a check before, but I've fixed it now 😊 Nothing had happened for over a week, I was just making sure nobody was waiting for me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ C++ entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] C++ Bucket Function unordered_map
4 participants