Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit C++ functions file #5521

Merged

Conversation

LesgoMega
Copy link
Contributor

@LesgoMega LesgoMega commented Oct 18, 2024

Description

  • Added recursion subsection on functions.md file for C++
  • Relates to issue 5486

Issue Solved

closes #5486

Type of Change

  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Oct 18, 2024
@mamtawardhani mamtawardhani added enhancement New feature or request c++ C++ entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: under review Issue or PR is currently being reviewed labels Oct 18, 2024
@mamtawardhani
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @LesgoMega please sign the CLA

@mamtawardhani mamtawardhani added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Oct 19, 2024
@LesgoMega
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @LesgoMega please sign the CLA

Good day, @mamtawardhani CLA has been signed. Thank you.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @LesgoMega 😄

The entry looks good for a second round of review! 🚀

@Sriparno08 Sriparno08 self-assigned this Oct 21, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Oct 21, 2024
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @LesgoMega!

@Sriparno08 Sriparno08 merged commit ad61d6f into Codecademy:main Nov 2, 2024
6 checks passed
Copy link

github-actions bot commented Nov 2, 2024

👋 @LesgoMega
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/functions

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ C++ entries enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit] C++ functions
4 participants