Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp variables #5499

Merged
merged 20 commits into from
Oct 18, 2024
Merged

Cpp variables #5499

merged 20 commits into from
Oct 18, 2024

Conversation

RashmitTopG
Copy link
Contributor

@RashmitTopG RashmitTopG commented Oct 15, 2024 •
edited by mamtawardhani
Loading

Description

Issue Solved

Closes #5491

Type of Change

FIxed Documentation for C++ Varibales added definitions and codeblocks.

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [✓] All writings are my own.
  • [✓] My entry follows the Codecademy Docs style guide.
  • [✓] My changes generate no new warnings.
  • [✓] I have performed a self-review of my own writing and code.
  • [✓] I have checked my entry and corrected any misspellings.
  • [✓] I have made corresponding changes to the documentation if needed.
  • [✓] I have confirmed my changes are not being pushed from my forked main branch.
  • [✓] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [✓] I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Oct 16, 2024
@mamtawardhani mamtawardhani linked an issue Oct 16, 2024 that may be closed by this pull request
[Edit] C++ variables #5491
Closed
3 tasks
mamtawardhani
mamtawardhani requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RashmitTopG please remove the other files from this branch. Only add the variables.md on this branch.
Thank you! 😄

@mamtawardhani mamtawardhani added enhancement New feature or request c++ C++ entries status: waiting for author hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest labels Oct 16, 2024
@mamtawardhani
Copy link
Collaborator

Hey @RashmitTopG, this PR has 3 files. Could you just stage the variables.md file and remove the other files from this branch please?

mamtawardhani
mamtawardhani approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @RashmitTopG 😃

The entry looks good for a second round of review! 🚀

content/cpp/concepts/variables/variables.md Outdated
@@ -1,6 +1,6 @@
---
Title: 'Variables'
Description: 'A variable refers to a storage location in the computer’s memory that one can set aside to save, retrieve, and manipulate data. To create a variable, the type must be specified and a value must be assigned to it.'
Description: 'A variable refers to a storage location in the computer’s memory that one can set aside to save, retrieve, and manipulate data. Variables are fundamental in programming as they enable dynamic data handling.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the description to not more than 160 characters

@dakshdeepHERE dakshdeepHERE self-assigned this Oct 18, 2024
@dakshdeepHERE dakshdeepHERE added the status: under review Issue or PR is currently being reviewed label Oct 18, 2024
dakshdeepHERE
dakshdeepHERE approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 🚀

@dakshdeepHERE dakshdeepHERE added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Oct 18, 2024
@dakshdeepHERE dakshdeepHERE merged commit 5638538 into Codecademy:main Oct 18, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @RashmitTopG
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/variables

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

Assignees

@mamtawardhani mamtawardhani

@dakshdeepHERE dakshdeepHERE

Labels
c++ C++ entries enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] C++ variables
3 participants
@RashmitTopG @mamtawardhani @dakshdeepHERE