Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept Entry] SIMILAR TO in SQL #5209

Merged
merged 17 commits into from
Oct 17, 2024
Merged

Conversation

saldanhad
Copy link
Contributor

Description

Added documentation for SIMILAR TO sql operator.

Issue Solved

Closes #5165

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@cigar-galaxy82 cigar-galaxy82 self-assigned this Sep 11, 2024
@saldanhad
Copy link
Contributor Author

saldanhad commented Sep 12, 2024

Hi @cigar-galaxy82, I have made the required changes in my latest commit, could you please approve to initialize the tests.

Regards,
Deepak

@cigar-galaxy82 cigar-galaxy82 added sql SQL entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Sep 26, 2024
@cigar-galaxy82
Copy link
Contributor

Hi @saldanhad thank you for contributing to Codecademy docs, I have suggested a few changes please modify them.

@saldanhad
Copy link
Contributor Author

Hi @cigar-galaxy82, thanks for your review, suggested changes are implemented.

Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merge, I did some description changes and few first person speech issues were there, thank you for the entry :)

@saldanhad
Copy link
Contributor Author

Thanks for the reviews, fixed linting, PR ready for merge.

@dakshdeepHERE
Copy link
Collaborator

@saldanhad we are waiting for the 1st reviewer's approval and thank u for the fix :)

@saldanhad
Copy link
Contributor Author

saldanhad commented Oct 2, 2024

@cigar-galaxy82, @dakshdeepHERE Could one of you please merge the PR, Thanks!

@dakshdeepHERE dakshdeepHERE merged commit c175602 into Codecademy:main Oct 17, 2024
6 checks passed
Copy link

👋 @saldanhad
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/sql/operators/similar-to

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@dakshdeepHERE
Copy link
Collaborator

Thank you for the contribution @saldanhad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] SIMILAR TO in SQL
3 participants