Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new entry: working with JSON in Go #5906

Merged
merged 11 commits into from
Jan 18, 2025
Merged

Add new entry: working with JSON in Go #5906

merged 11 commits into from
Jan 18, 2025

Conversation

Franceskynov
Copy link
Contributor

Description

Topic: Working with JSON in Go
File added: docs/content/go/concepts/working-with-json/working-with-json.md
Open issue

Issue Solved

Closes #5905

Type of Change

- Adding a new entry

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@PragatiVerma18 PragatiVerma18 self-assigned this Jan 10, 2025
PragatiVerma18
PragatiVerma18 requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Franceskynov, thanks for contributing to docs, I have some suggestions and have left comments. Please check and make the changes. Let me know if you need any help or have any questions.

.gitignore Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
content/go/concepts/working-with-json/working-with-json.md Outdated Show resolved Hide resolved
PragatiVerma18
PragatiVerma18 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Franceskynov, this is now good for a second review! 🚀

@Franceskynov Franceskynov force-pushed the working-with-json-in-go branch from 788a453 to 6268522 Compare January 13, 2025 04:41
@avdhoottt avdhoottt self-assigned this Jan 13, 2025
avdhoottt
avdhoottt approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@avdhoottt avdhoottt added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 18, 2025
@avdhoottt avdhoottt merged commit ad184eb into Codecademy:main Jan 18, 2025
7 checks passed
@github-actions GitHub Actions
Copy link

👋 @Franceskynov
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/go/working-with-json

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

Assignees

@PragatiVerma18 PragatiVerma18

@avdhoottt avdhoottt

Labels
go Go/Golang entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Entry] Subject: Working with Json in Go
4 participants
@Franceskynov @CLAassistant @PragatiVerma18 @avdhoottt