Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben gcp docs #328

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Ben gcp docs #328

merged 10 commits into from
Oct 18, 2022

Conversation

benfoley
Copy link
Contributor

This PR includes greater detail about the process of starting a GCP account, getting billing, APIs and quotas set up. Also cleaned up a few things. Tested by following the instructions from a fresh google account and it worked! yay.

@benfoley benfoley marked this pull request as draft October 17, 2022 06:55
@benfoley benfoley marked this pull request as ready for review October 17, 2022 07:27
Copy link
Contributor

@nicklambourne nicklambourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some suggestions here and there 🏉

docs/wiki/elpis-workshop.md Outdated Show resolved Hide resolved
docs/wiki/handy-gcp-commands.md Outdated Show resolved Hide resolved
docs/wiki/handy-gcp-commands.md Show resolved Hide resolved
docs/wiki/handy-gcp-commands.md Outdated Show resolved Hide resolved
docs/wiki/handy-gcp-commands.md Outdated Show resolved Hide resolved
docs/wiki/setup-google-cloud-account.md Outdated Show resolved Hide resolved
docs/wiki/setup-google-cloud-account.md Outdated Show resolved Hide resolved
docs/wiki/setup-google-cloud-account.md Outdated Show resolved Hide resolved
docs/wiki/setup-google-cloud-account.md Outdated Show resolved Hide resolved
docs/wiki/setup-google-cloud-account.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@harrykeightley harrykeightley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some small fixes.

docs/wiki/handy-gcp-commands.md Outdated Show resolved Hide resolved
docs/wiki/make-elpis-release.md Outdated Show resolved Hide resolved
docs/wiki/viewing-elpis-training-log-file.md Outdated Show resolved Hide resolved
docs/wiki/viewing-elpis-training-log-file.md Outdated Show resolved Hide resolved
@benfoley benfoley merged commit cf526c0 into master Oct 18, 2022
@benfoley benfoley deleted the ben-gcp-docs branch October 18, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants