Fix for Nim 2.0.0 - 2.0.4 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your PR. I already had a bigger PR in the work that fixed the global scope issue. I'll rebase your PR on top the existing one and fix the conflict once it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated infix C++ expressions are verbatim text, brutal violations of grouping and precedence were observed under Nim 2.x!!! For example, Nim codegen tried to negate "x == y" as "!x == y". That's why I insulated all occurences with ().
Araq recommended to avoid construction of wrapped STL objects in top-level scope (https://forum.nim-lang.org/t/12518). Fixed unit tests to follow this recommendation.
After performing steps (1,2) cppstl builds and passes all tests when compiled with Nim 2.0.0, 2.0.2 and 2.0.4
PS. It still fails on latest Nim 2.0.8 release because of C++ compile-time errors related to unary 'operator*', but this is unrelated issue.