Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various Nim 2.0 issue (unary operator, global scope, $ templating) #32

Merged
merged 22 commits into from
Sep 16, 2024

Conversation

Clonkk
Copy link
Owner

@Clonkk Clonkk commented Aug 19, 2024

No description provided.

@Clonkk
Copy link
Owner Author

Clonkk commented Aug 20, 2024

Updated dollar proc.

Strange stuff happening.

One fail with
nim cpp -r tests/destroy_bug_15.nim

/Users/regis.caillaud/.cache/nim/destroy_bug_15_d/@m..@scppstl@sstd_vector.nim.cpp: In function 'tyObject_Foo__ts4nvcjAv78U4K2CTDA9a9bA* X5BX5D___destroy95bug954953_u230(TY__sufWQvCeYFKA6EJnXVsnlA*, NI)':
/Users/regis.caillaud/.cache/nim/destroy_bug_15_d/@m..@scppstl@sstd_vector.nim.cpp:311:62: error: no match for 'operator*' (operand type is 'TY__sufWQvCeYFKA6EJnXVsnlA' {aka 'std::vector<tyObject_Foo__ts4nvcjAv78U4K2CTDA9a9bA>'})
  311 |         nimln_(363);    checkIndex__destroy95bug954953_u236((*((TY__sufWQvCeYFKA6EJnXVsnlA) ((*self_p0)))), i);
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      

The other fail with Nim error compile time as if the proic didn't exist
nim cpp -r -d:dollar1 tests/destroy_bug_15.nim

Expression: echo v
  [1] v: CppVector[destroy_bug_15.Foo]

Expected one of (first mismatch at [position]):
[1] proc echo(x: varargs[typed, `$`])

@Clonkk
Copy link
Owner Author

Clonkk commented Aug 20, 2024

@jmgomez (sorry to ping you again) Do you have any insight into what changed in the C++ codegen that can result in this ?

@Clonkk Clonkk changed the title fix $ proc copying data Fix various Nim 2.0 issue (unary operator, global scope, $ templating) Sep 16, 2024
@Clonkk Clonkk merged commit dff4752 into master Sep 16, 2024
4 of 6 checks passed
@Clonkk Clonkk deleted the fix-destructor branch September 16, 2024 09:29
@Clonkk Clonkk restored the fix-destructor branch September 16, 2024 09:30
@Clonkk Clonkk deleted the fix-destructor branch September 16, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant