Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper-rustls: add ring Rustls backend & use it by default #140

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

blind-oracle
Copy link
Contributor

Recently rustls crate switched to the aws-lc-rs crypto backend by default (probably because it's FIPS certified) which requires a C compiler to build, which adds unnecessary complexity.

This PR makes hyper-rustls use pure Rust ring backend by default with an option to use aws-lc-rs through rustls-tls-aws feature.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

serprex
serprex previously approved these changes Sep 4, 2024
Cargo.toml Outdated Show resolved Hide resolved
serprex
serprex previously approved these changes Sep 4, 2024
src/lib.rs Show resolved Hide resolved
@serprex serprex merged commit d9c05a1 into ClickHouse:main Sep 4, 2024
6 checks passed
@blind-oracle blind-oracle deleted the ring branch September 4, 2024 20:24
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@loyd
Copy link
Collaborator

loyd commented Sep 17, 2024

@blind-oracle

... requires a C compiler to build, which adds unnecessary complexity.
This PR makes hyper-rustls use pure Rust ring backend by default with an option to use aws-lc-rs through rustls-tls-aws feature.

Isn't ring non pure-Rust? https://github.com/briansmith/ring/blob/7c0024abaf4fd59250c9b79cc41a029aa0ef3497/build.rs#L348

@serprex
Copy link
Member

serprex commented Sep 17, 2024

they were somewhat inaccurate, build issues tend to be NASM related on Windows, but it's been improving: rustls/rustls#1913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants