-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(derive): use rename_all rule for container when naming fields #117
Merged
serprex
merged 5 commits into
ClickHouse:main
from
v3xro:feat/follow-serde-rename-all-rule
Sep 5, 2024
Merged
feat(derive): use rename_all rule for container when naming fields #117
serprex
merged 5 commits into
ClickHouse:main
from
v3xro:feat/follow-serde-rename-all-rule
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyd
reviewed
Aug 4, 2024
serprex
force-pushed
the
feat/follow-serde-rename-all-rule
branch
from
September 5, 2024 02:30
637381f
to
12925b4
Compare
serprex
force-pushed
the
feat/follow-serde-rename-all-rule
branch
from
September 5, 2024 02:31
12925b4
to
8eaea2e
Compare
serprex
previously approved these changes
Sep 5, 2024
slvrtrn
reviewed
Sep 5, 2024
serprex
force-pushed
the
feat/follow-serde-rename-all-rule
branch
from
September 5, 2024 12:55
720464f
to
c233d54
Compare
serprex
force-pushed
the
feat/follow-serde-rename-all-rule
branch
from
September 5, 2024 12:58
c233d54
to
bc6500c
Compare
slvrtrn
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Not an expert in serde-derive, let me know if there's a better way to express this.