Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): use rename_all rule for container when naming fields #117

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

v3xro
Copy link
Contributor

@v3xro v3xro commented Jul 30, 2024

Fixes #71

Not an expert in serde-derive, let me know if there's a better way to express this.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

derive/src/lib.rs Outdated Show resolved Hide resolved
@serprex serprex force-pushed the feat/follow-serde-rename-all-rule branch from 637381f to 12925b4 Compare September 5, 2024 02:30
@serprex serprex force-pushed the feat/follow-serde-rename-all-rule branch from 12925b4 to 8eaea2e Compare September 5, 2024 02:31
@serprex
Copy link
Member

serprex commented Sep 5, 2024

@loyd @slvrtrn I added a test case to v3xro's fork. There's one ambiguity which may want to be changed: rename_all camelCase overrides an explicit snake_case rename tag, see fix_id

serprex
serprex previously approved these changes Sep 5, 2024
tests/it/main.rs Outdated Show resolved Hide resolved
@serprex serprex force-pushed the feat/follow-serde-rename-all-rule branch from c233d54 to bc6500c Compare September 5, 2024 12:58
@serprex serprex merged commit 8c55a9d into ClickHouse:main Sep 5, 2024
6 checks passed
@v3xro v3xro deleted the feat/follow-serde-rename-all-rule branch September 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all doesn't work?)
5 participants