Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a welding store #77279

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Milopetilo
Copy link
Contributor

Summary

Content "Added a welding store"

Purpose of change

Closes #53685.
A quick googling shows that while not quite as common as normal hardware stores, welding stores are not too uncommon of a sight in NE. In order to account for this I have made them half as common as a single type of hardware store, meaning there is a ratio of ~1 welding store for every 8 hardware stores, which seems reasonable to me.

Describe the solution

Added a new welding store.

Describe alternatives you've considered

Make a variant of the hardware store which just happens to have a bit more welding supplies.

Testing

Game loads, building spawns, items & furniture spawn, terrain is correct, vehicles don't break things

Additional context

Screenshots c:

image

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 23, 2024
@Milopetilo Milopetilo marked this pull request as draft October 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welding store
1 participant