Fix NPCs stealing player default name #77268
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "NPCs stealing player default name"
Purpose of change
Indeed a bug caused by #76935
Closes #77235
Character::pick_name()
is used inCharacter::randomize()
, so NPCs use it now. It can setname
to the option-defined default name (DEF_CHAR_NAME), which is not intended for NPCs.Describe the solution
Add
is_avatar()
check, one-liner.Describe alternatives you've considered
Testing
With default name as "Default Name!":
Starting game with "Play Now!":Starting game with "Random Character":
And the same with empty default name:
play now
random character
Additional context