Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exodii weaponmaster #77255

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

People tie too much stuff to hub 01; i don't like it
also i don't like that there is too little npcs in rocky butte

Describe the solution

add weaponmaster that partially handles weapon and armor trade; maybe in future they could do more, but man i'd rather yell at code for a week than make npc

Describe alternatives you've considered

remove it's merchant abilities, just making them vibin' here

Testing

TBD

Additional context

perfect counterpart to untranslateable dialogues of Rubik

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 22, 2024
@John-Candlebury
Copy link
Member

Oh cool stuff.

@AudBobb
Copy link
Contributor

AudBobb commented Oct 22, 2024

That's all the grammar issues I see, seems like a good addition to the exodii to try and make them more interesting! Interesting concept for the NPC too, I look forward to trading with spider man.

@PatrikLundell
Copy link
Contributor

If Rubik won't trade certain stuff he'd probably need dialog to direct you to the appropriate trader(s), with the message that they don't understand Anglic, so you'd have to communicate using gestures.
One thing you could do is to use Rubik's dialog to tell you the names of them so you could have one dialog start where you call the name of the one you address, and one for a general "Hello there". You could also have introductions, one for when you know the name of your counterpart (only presenting yourself), and one for when you make a general call and your counterpart introduces itself first and you thereafter (automatically, unless you want a rude alternative, which I wouldn't provide if I tried to write it).

"&Weaponmaster seems to clean some weapon, but as you approach them, they call someone to pick a gun, and turn to you.",
"&Weaponmaster seems to polish some armor, but turn to you the second you enter the room."
"&The Weaponmaster seems to be tinkering on something, but turns their chair to you as you approach.",
"&The Weaponmaster seems to be cleaning some sort of weapon, but as you approach them, they signal to bystanding worker to take the weapon, and turn to you.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they signal to bystanding worker -> they signal to a bystanding worker

"//": "mute by choise, and deaf most of the time (don't like to turn on the hearing cbm unless for job)",
"dynamic_line": "&What you see looks like the back of a mechanical spider, with at least a dozen crude but polished metal arms going from the enormously wide spine and shoulders. Spine of a creature, meanwhile, sits in an awkward-looking chair, doing something on a wide, heavily lighted workbench. Creature seems to be busy with something.",
"//": "mute by choice, and deaf most of the time (don't like to turn on the hearing cbm unless for job)",
"dynamic_line": "&What you see looks like the back of a mechanical spider, with at least a dozen crude but polished metal arms coming from the enormously wide spine and shoulders. Spine of a creature, meanwhile, sits in an awkward-looking chair, doing something on a wide, heavily lighted workbench. Creature seems to be busy with something.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spine of a creature, meanwhile, -> The spine of the creature, meanwhile,
Creature seems to -> The creature seems to

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • &Still completely mute, it shows you something you had initially missed. The entire wall behind the workbench is full of various weapons; some as big as modern rifles, a few as large as the machine guns installed on aircraft, and one that looks like a dismantled tank turret. Melee weapons were not forgotten, from moderately-sized swords and clubs to war hammers twice the height of a human, and what you can describe only as "boots for mecha". Then it points to a sign near you that shows three things: the carved pictograms of coins, some sign you are not familiar with, and a pictogram of a bullet - all things considered, this creature is either a weaponmaster, or a weapon merchant.
  • &The Weaponmaster seems seems to be polishing some armor, but they turn towards you the second you enter the room.
  • &The Weaponmaster seems to be cleaning some sort of weapon, but as you approach them, they signal to bystanding worker to take the weapon, and turn to you.
  • &The Weaponmaster seems to be tinkering on something, but turns their chair to you as you approach.
  • Weaponmaster
  • Who-… Wha-… What are you?
  • [You pull off your backpack, and start to pull out items you deem worthy of trading. The weaponmaster finally looks interested.]

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants