Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamethrowers count as firestarters for lighting up bombs #77227

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Flamethrowers count as firestarters for lighting up bombs"

Purpose of change

Describe the solution

  • Added firestarter use_action to flamethrower_base.
  • In use_charges allowed checking for GUN type of items.

Describe alternatives you've considered

None.

Testing

Got dynamite and a flamethrower. Wielded dynamite and activated it. Dynamite was lit, flamethrower lost 1 charge of napalm.

Additional context

AFAIK currently there's no underbarrel flamethrowers in vanilla or built-in mods, but if some modder wants to add such a thing to his mod, I suppose this gunmod won't work. Should I also add a check for GUNMOD type of items?

@Night-Pryanik Night-Pryanik added Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Oct 21, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 21, 2024
@AudBobb
Copy link
Contributor

AudBobb commented Oct 21, 2024

Now I'm no flamethrower expert, but aren't the flames coming out of a flamethrower massive? I feel like trying to hold the flamethrower in one hand, and a stick of dynamite in the other would be pretty risky, and you'd likely end up burning yourself, or just igniting the whole stick of dynamite in the process. Also do you not need to light the pilot light on the flamethrower before using it, meaning you would still realistically need another source of flame for this process anyways, unless we are just keeping the flamethrower pilot light lit in our back pocket?

Edit: Looking at flamethrowers, it seems like they actually have a built in ignitor for the pilot light, so maybe we are just using that as the ignition source for the dynamite? If so, just ignore me lol

@Night-Pryanik
Copy link
Contributor Author

I suppose lighting a fuse is perfectly doable.
1546087265_German soldier lighting his cigarette with a flamethrower, 1917

@AudBobb
Copy link
Contributor

AudBobb commented Oct 21, 2024

Fair enough xD

<< Not a flamethrower expert

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 21, 2024
@Maleclypse Maleclypse merged commit aeaca88 into CleverRaven:master Oct 22, 2024
29 checks passed
@Night-Pryanik Night-Pryanik deleted the guns-use-charges-too branch October 22, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flamethrower doesn't count as source of fire for purpose of lighting up bombs
3 participants