Not too generous Smokes #77225
Merged
Not too generous Smokes #77225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Whenever you complete a quest for smokes, you can ask smokes for item rewards, which gives the player basically 500 barter value credit for buying his stuff, which is rather on odds with the merch he gave beforehand. I feel like this is an oversight and i'm fixing it.
Describe the solution
give
"has_generic_rewards": falseto smokes' mission jsons.Describe alternatives you've considered
Letting the oversight be.
Increasing the merch pay out for the back bay mission in particular, but that's a question for someone else to discuss.
Testing
Additional context