Fix: weariness makes hauling faster instead of slower; set weariness tracker in debug

[Brambor]

Summary

Bugfixes "Fix: weariness makes hauling faster instead of slower"

Purpose of change

• Fix Weary penalty doesn't apply to hauling, actually speed ​​it up #76944
• debug: Add a way of changing weariness in the debug menu for easier testing.

Describe the solution

• fix: divide instead of multiply
• debug: add getter and setter to a private variable (ugh...)

Describe alternatives you've considered

• fix: look at other activities, make hauling move cost more general, it would take more time and potentially introduce more bugs
• debug: make the variable public (since it has setter and getter, it kinda is); But the implemented way, naming the methods debug_* it is more clear that the programmer shouldn't use them. Open to suggestions!

Testing

• fix: compiled game before and after, the hauling took much longer. I moved 8 refrigerator tanks with AIM one tile, which takes 13-14 seconds without weariness, 27 seconds being Very Weary, 54-55 seconds being Extremely Weary

  • after, test with different weariness. Hauling seems to be moderate activity, since it takes 4 times as long with Extreme Weariness
    

• debug:

  1. set value of weariness tracker:
     1. debug menu
     2. player
     3. edit player/NPC
     4. you
     5. Set needs
     6. Weariness tracker
     7. <set to some value>
     8. or just F11 p p ENTER n W <set to some value> in my case:
     • 0 Fresh
     • 1000000 Light
     • 2000000 Moderate
     • 3000000 Weary
     • 3500000 Very
     • 4000000 Extreme
  2. wait a turn
     - Weariness updates in the side menu
     - You get a message, if weariness changed
     - You get the right effect

Additional context

Not sure, when the player would notice an incoming zombie. Would the Safe mode trigger on time when hauling a big item and being very weary?

[harakka]

Do you happen to know if this is also in 0.H or was the bug introduced after? If it is, backport would be cool once this is approved.

[Brambor]

It was there since the beginning of weariness, unless the wearines implementation flipped from 1/val to val/1.

• Basic Weariness Implementation #43985

[Brambor]

I hope it is all right if I mark it as a backport candidate then.

If minimizing the code is better, maybe only the change from * to / could be backported.