correct height when a uilist has desired_bounds not including height #77219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the desired bounds doesn't include a height, use the screen height instead of -1 as the desired height.
github-actions
bot
added
<Bugfix>
Brambor
reviewed
Oct 21, 2024
Brambor
reviewed
Oct 21, 2024
db48x
force-pushed
the
uilist-categories-height-bug
branch
from
64125dc
to
a9a0c10
Compare
github-actions
bot
added
astyled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "calculate correct height when a uilist has desired_bounds not including a height"
Purpose of change
Fixes #77191
Describe the solution
When the desired bounds doesn't include a height, use the screen height instead of -1 as the desired height.
Screencast.from.2024-10-20.21-25-04.mp4