Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstruct simple furniture in the dark #77165

Merged

Conversation

sparr
Copy link
Member

@sparr sparr commented Oct 19, 2024

Summary

Features "Deconstruct simple furniture in the dark"

Purpose of change

Almost all EASY_DECONSTRUCT furniture converts 1:1 to an equivalent item. That we need a construction step to change the type of what is conceptually the same object is an implementation detail.

Describe the solution

This furniture can now be deconstructed in the dark by checking the construction group.

Describe alternatives you've considered

Testing

Deconstructed some things in the dark. Tried and failed to deconstruct non-EASY things.

Additional context

There are a few less-direct deconstructions, like turning a black shard bed into black glass shards. These still feel like they should be doable in the dark, but a few of them might be worth removing the flag from.

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 19, 2024
@dseguin dseguin merged commit d5b7e72 into CleverRaven:master Oct 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants